Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render prop for color picker component #538

Closed
nickofthyme opened this issue Feb 5, 2020 · 0 comments · Fixed by #545
Closed

Render prop for color picker component #538

nickofthyme opened this issue Feb 5, 2020 · 0 comments · Fixed by #545
Labels
enhancement New feature or request :legend Legend related issue

Comments

@nickofthyme
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Allow color picker render prop

Describe the solution you'd like
Allow renderColorPicker prop to pass value.

interface Props {
  onChange: (color: string) => void;
}
type renderColorPicker = (props: Props) => React.Component;

Describe alternatives you've considered
Build our own color picker. For consistency and desire not to import EUI into elastic charts, the above option is preferable.

Additional Context
The logic to store colors in memory is still available in the legend so this would require handling the handshake between these two things.

Related to old issue #23

@nickofthyme nickofthyme added enhancement New feature or request :legend Legend related issue labels Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request :legend Legend related issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant