fix: empty domain error for ordinal x scale #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markov00
reviewed
Feb 5, 2020
| @@ -93,6 +93,11 @@ export function mergeXDomain( | |||
| minInterval = customMinInterval || computedMinInterval; | |||
| } | |||
|
|
|||
| // TODO: Check for empty data before computing domain | |||
| if (seriesXComputedDomains.length === 0) { | |||
| seriesXComputedDomains = [0, 0]; | |||
There was a problem hiding this comment.
This should be just one single value [0] because we are in ordinal domain and we don't want duplicated domain values
There was a problem hiding this comment.
it's also better to move that inside the computeOrdinalDataDomain of domains.ts
Codecov Report
@@ Coverage Diff @@
## master #536 +/- ##
==========================================
+ Coverage 75.56% 75.81% +0.24%
==========================================
Files 181 193 +12
Lines 5689 5846 +157
Branches 1103 1117 +14
==========================================
+ Hits 4299 4432 +133
- Misses 1374 1397 +23
- Partials 16 17 +1
Continue to review full report at Codecov.
|
markov00
pushed a commit
that referenced
this pull request
Feb 5, 2020
## [17.0.2](v17.0.1...v17.0.2) (2020-02-05) ### Bug Fixes * empty domain error for ordinal x scale ([#536](#536)) ([ce4e84f](ce4e84f))
|
🎉 This PR is included in version 17.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
## [17.0.2](elastic/elastic-charts@v17.0.1...v17.0.2) (2020-02-05) ### Bug Fixes * empty domain error for ordinal x scale ([opensearch-project#536](elastic/elastic-charts#536)) ([2e92609](elastic/elastic-charts@2e92609))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue related to empty domain.
If the data is an empty array and the
xScaleTypeisOrdinalthescaleBandfromd3-scalewill runAnd throw a
RangeError. This is a quick fix, but ideally, we revisit this to avoid unnecessarily computing the domain if the data is empty for all specs.Checklist