Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: redux dev tools config #465

Merged
merged 3 commits into from
Dec 2, 2019
Merged

fix: redux dev tools config #465

merged 3 commits into from
Dec 2, 2019

Conversation

nickofthyme
Copy link
Collaborator

Summary

Fix redux dev tools config to read from window.

Upgrade typescript to 3.7

Checklist

  • Unit tests were updated or added to match the most common scenarios
  • Each commit follows the convention

@nickofthyme nickofthyme requested a review from markov00 December 2, 2019 20:49
markov00
markov00 approved these changes Dec 2, 2019
View reviewed changes
Copy link
Member

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

codecov-io commented Dec 2, 2019 •
edited
Loading

Codecov Report

Merging #465 into master will decrease coverage by 0.08%.
The diff coverage is 81.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #465      +/-   ##
==========================================
- Coverage   83.79%   83.71%   -0.09%     
==========================================
  Files         158      169      +11     
  Lines        4702     4850     +148     
  Branches      952      965      +13     
==========================================
+ Hits         3940     4060     +120     
- Misses        748      774      +26     
- Partials       14       16       +2
Impacted Files Coverage Δ
src/index.ts 100% <ø> (ø) ⬆️
src/components/chart_resizer.tsx 70.21% <100%> (ø) ⬆️
src/specs/settings.tsx 100% <100%> (ø) ⬆️
src/components/chart.tsx 77.01% <77.77%> (-0.9%) ⬇️
src/mocks/series/series.ts 81.96% <0%> (ø)
src/mocks/specs/specs.ts 66.66% <0%> (ø)
src/mocks/scale/index.ts 100% <0%> (ø)
src/mocks/index.ts 100% <0%> (ø)
src/mocks/series/index.ts 100% <0%> (ø)
src/mocks/series/seriesIdentifiers.ts 93.33% <0%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4edbb85...30f49b6. Read the comment docs.

@nickofthyme nickofthyme merged commit 89d5364 into elastic:master Dec 2, 2019
@nickofthyme nickofthyme deleted the fix/redux-dev-tools branch December 2, 2019 22:50
markov00 pushed a commit that referenced this pull request Dec 2, 2019
@semantic-release-bot
chore(release): 15.0.1 [skip ci]
1b85ac7 
## [15.0.1](v15.0.0...v15.0.1) (2019-12-02)

### Bug Fixes

* redux dev tools config ([#465](#465)) ([89d5364](89d5364))
@markov00
Copy link
Member

markov00 commented Dec 2, 2019

🎉 This PR is included in version 15.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Dec 2, 2019
@markov00 markov00 mentioned this pull request Dec 10, 2019
Merged
4 tasks
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Feb 10, 2022
@semantic-release-bot
chore(release): 15.0.1 [skip ci]
ec7bf65 
## [15.0.1](elastic/elastic-charts@v15.0.0...v15.0.1) (2019-12-02)

### Bug Fixes

* redux dev tools config ([opensearch-project#465](elastic/elastic-charts#465)) ([ea1e779](elastic/elastic-charts@ea1e779))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markov00 markov00 markov00 approved these changes

Assignees
No one assigned
Labels
released Issue released publicly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nickofthyme @codecov-io @markov00