fix: switch to momentjs to handle timezones #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
to be merged after #430 |
Codecov Report
@@ Coverage Diff @@
## master #436 +/- ##
==========================================
+ Coverage 97.87% 97.88% +<.01%
==========================================
Files 40 41 +1
Lines 2921 2925 +4
Branches 706 708 +2
==========================================
+ Hits 2859 2863 +4
Misses 55 55
Partials 7 7
Continue to review full report at Codecov.
|
nickofthyme
requested changes
Oct 22, 2019
Luxon use Init.DateTimeFormatter for handling timezones, but this is browser dependent. Moving to momentjs will allow us to be compliant to Kibana
markov00
force-pushed
the
add-momentjs
branch
from
d75e78c to
2504e9a
Compare
nickofthyme
approved these changes
Oct 22, 2019
|
jenkins test this please error on downloading nodejs |
|
retest |
|
jenkins test this please |
1 similar comment
|
jenkins test this please |
markov00
pushed a commit
that referenced
this pull request
Oct 23, 2019
## [13.5.7](v13.5.6...v13.5.7) (2019-10-23) ### Bug Fixes * switch to momentjs to handle timezones ([#436](#436)) ([a9f98c8](a9f98c8))
|
🎉 This PR is included in version 13.5.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
## [13.5.7](elastic/elastic-charts@v13.5.6...v13.5.7) (2019-10-23) ### Bug Fixes * switch to momentjs to handle timezones ([opensearch-project#436](elastic/elastic-charts#436)) ([cd15932](elastic/elastic-charts@cd15932))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The current used time library,
Luxonis usingIntl.DateTimeFormatteras the main source for handling time zones. That library depends on browsers implementation. IE11 doesn't have any timezone and it will need a polyfill.This PR replace
luxonwithmomentjsandmoment-timezone. I'm leavingluxonas a devDependency on the tests and on stories. We can remove it in a future phase.momentjsandmoment-timezoneare configured aspeerDependencysince Kibana is already using that library.I've checked that fix cross-linking the build with Kibana. I've tested various timezones in Discover chart.
fix #428
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.src/index.ts(and stories only import from../srcexcept for test data & storybook)