fix(tickformatter): add timeZone to tickFormatter

[markov00]

Summary

to correctly handle a the tick formatting on time based series, we need to share the timeZone
parameter to the tickFormatter. When the tickFormatter is an external function, the user can
manually configure that parameter, but for the niceTimeFormatter we don't have that option already.
Instead of adding a breaking change I've added an optional parameter to the tickFormat props to
share the configured timeZone parameter

fix #427

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

• Any consumer-facing exports were added to src/index.ts (and stories only import from ../src except for test data & storybook)
• [ ] This was checked for cross-browser compatibility, including a check against IE11
• Proper documentation or storybook story was added for features that require explanation or tutorials
• Unit tests were updated or added to match the most common scenarios
• Each commit follows the convention

[codecov-io]

Codecov Report

Merging #430 into master will decrease coverage by 0.08%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #430      +/-   ##
==========================================
- Coverage   97.85%   97.77%   -0.09%     
==========================================
  Files          39       40       +1     
  Lines        2896     2921      +25     
  Branches      701      706       +5     
==========================================
+ Hits         2834     2856      +22     
- Misses         55       58       +3     
  Partials        7        7

Impacted Files	Coverage Δ
src/chart_types/xy_chart/utils/specs.ts	100% <ø> (ø)	⬆️
src/chart_types/xy_chart/tooltip/tooltip.ts	93.84% <100%> (+0.09%)	⬆️
src/utils/data/formatters.ts	86.36% <100%> (ø)
src/chart_types/xy_chart/utils/axis_utils.ts	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d43dbc...7cca9e8. Read the comment docs.

[nickofthyme]

LGTM, only a few suggestions.

[rshen91]

This looks clear to me - Is there a way for a user to break this with bad input? I see that timeZone is of type string for input like 'utc+3'. Doees moment.js just handle bad timezones like timeZone: 'blarg'?

[nickofthyme]

@rshen91 with the addition of moment, it appears to fail gracefully by falling back to the local/browser time zone.

[markov00]

@rshen91 with the addition of moment, it appears to fail gracefully by falling back to the local/browser time zone.

@nickofthyme @rshen91 do we want to catch that moment exception and throw just a more "nicer" console.warn ?

[nickofthyme]

@nickofthyme @rshen91 do we want to catch that moment exception and throw just a more "nicer" console.warn ?

No I don't think that is needed. Wylie pointed out our lack of error catching, which he's right. I think it's a bigger issue to handle all bad inputs to chart "nicely" in both dev and production.

One thing we could add for this is an enum but that would limit the flexibility of kibana to just pass a string. I think moment.tz is resilient enough to handle most edge cases 💪 .

[markov00]

🎉 This PR is included in version 13.5.6 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)

Your semantic-release bot 📦🚀