Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: align series names on splitted series configuration #421

Merged
merged 1 commit into from
Oct 17, 2019

Conversation

markov00
Copy link
Member

Summary

This PR align the series name when using a splitted series accessor. The names of the series now
uses the value coming from the splitted series accessor, independently on how many series are
computed

fix #420

Before the fix:
Oct-17-2019 12-30-12

After the fix:

Oct-17-2019 12-30-03

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

  • [ ] Any consumer-facing exports were added to src/index.ts (and stories only import from ../src except for test data & storybook)
  • [ ] This was checked for cross-browser compatibility, including a check against IE11
  • [ ] Proper documentation or storybook story was added for features that require explanation or tutorials
  • Unit tests were updated or added to match the most common scenarios
  • Each commit follows the convention

This commit align the series name when using a splitted series accessor. The names of the series now
uses the value coming from the splitted series accessor, independentely on how many series are
computed

fix elastic#420
@markov00 markov00 added :specs Chart specifications related issue bug Something isn't working labels Oct 17, 2019
@codecov-io
Copy link

codecov-io commented Oct 17, 2019

Codecov Report

Merging #421 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #421      +/-   ##
==========================================
+ Coverage   97.85%   97.85%   +<.01%     
==========================================
  Files          39       39              
  Lines        2894     2896       +2     
  Branches      700      701       +1     
==========================================
+ Hits         2832     2834       +2     
  Misses         55       55              
  Partials        7        7
Impacted Files Coverage Δ
src/chart_types/xy_chart/legend/legend.ts 95.23% <100%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1725e4...04d0aa3. Read the comment docs.

Copy link
Collaborator

@nickofthyme nickofthyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tooltip label looks good too

Copy link
Contributor

@rshen91 rshen91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and I like the added test

@markov00 markov00 merged commit bbecbcc into elastic:master Oct 17, 2019
@markov00 markov00 deleted the fix-splittedseries-name branch October 17, 2019 15:37
markov00 pushed a commit that referenced this pull request Oct 17, 2019
## [13.5.3](v13.5.2...v13.5.3) (2019-10-17)

### Bug Fixes

* align series names on splitted series configuration ([#421](#421)) ([bbecbcc](bbecbcc)), closes [#420](#420)
@markov00
Copy link
Member Author

🎉 This PR is included in version 13.5.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Oct 17, 2019
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released Issue released publicly :specs Chart specifications related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong series name on legend when using splitSeriesAccessors with a single series
4 participants