-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nice option for axis ticks #397
Labels
Comments
1 task
3 tasks
10 tasks
@nickofthyme do you remember a specific SB story that shows that tick alignment problem? |
No this was so long ago I can't remember what problems there were with tick alignments. |
🎉 This issue has been resolved in version 28.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Is your feature request related to a problem? Please describe.
Allow user to set the option for
nice
tick ending values.Describe alternatives you've considered
User manually sets the domain based on dataset
Additional context
An attempt was made in #384 but ran into issues with ticks aligning to the geometry domain.
See this branch for attempt master...nickofthyme:feat/nice-ticks
computeSeriesDomains
computes thexDomain
andyDomains
which are then passed to all subsequent function. I think this would be the best place to set the nice value so the domain is set from the beginning.Better yet is this could return the
xScale
andyScales
that would be better so the scale is not instantiated in thegetAxisTicksPositions
and then ingetScaleForAxisSpec
The text was updated successfully, but these errors were encountered: