fix(reactive_chart): fix order of instantiation of onBrushEnd callback #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wait for setState to finish before calling onBrushEnd, in the event the callback triggers a rerender. fixes elastic#360
nickofthyme
added
bug
Codecov Report
@@ Coverage Diff @@
## master #376 +/- ##
==========================================
+ Coverage 98.25% 98.27% +0.02%
==========================================
Files 38 38
Lines 2801 2784 -17
Branches 661 657 -4
==========================================
- Hits 2752 2736 -16
Misses 44 44
+ Partials 5 4 -1
Continue to review full report at Codecov.
|
2 tasks
markov00
approved these changes
Sep 16, 2019
| @@ -76,6 +76,10 @@ class Chart extends React.Component<ReactiveChartProps, ReactiveChartState> { | |||
| }, | |||
| }; | |||
|
|
|||
| componentWillUnmount() { | |||
| window.removeEventListener('mouseup', this.onEndBrushing); | |||
| } | |||
|
🎉 This PR is included in version 12.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
markov00
changed the title
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
## [12.0.2](elastic/elastic-charts@v12.0.1...v12.0.2) (2019-09-16) ### Bug Fixes * **reactive_chart:** fix order of instantiation of onBruchEnd callback ([opensearch-project#376](elastic/elastic-charts#376)) ([42cd1e7](elastic/elastic-charts@42cd1e7)), closes [opensearch-project#360](elastic/elastic-charts#360)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue found in SIEM where the
onBrushEndcallback triggers a URL change and thus a rerender of the page andChartcomponents on the page. The workaround solution was to add a500mssetTimeoutto allow time for the state to update before calling theonBrushEndcallback.The solution as suggested by @FrankHassanabad, is to invoke the
onBrushEndcallback following the completion of thesetStatemethod.fixes #360
Screenshot
Notice no console errors when brushing chart and successful update of time range and chart.
Additionally, added
componentWillUnmountmethod to ensurewindow.removeEventListeneris called onmouseupevent in the case where theChartis unmounted before this event is called.Checklist