Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(remove engine): remove node engine and commitizen dep #363

Merged
merged 1 commit into from
Aug 30, 2019

Conversation

nickofthyme
Copy link
Collaborator

@nickofthyme nickofthyme commented Aug 29, 2019

Summary

Update node engine to >=10

closes #359

Checklist

@nickofthyme nickofthyme requested a review from markov00 August 29, 2019 20:46
@codecov-io
Copy link

codecov-io commented Aug 29, 2019

Codecov Report

Merging #363 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #363   +/-   ##
=======================================
  Coverage   98.26%   98.26%           
=======================================
  Files          38       38           
  Lines        2772     2772           
  Branches      654      654           
=======================================
  Hits         2724     2724           
  Misses         44       44           
  Partials        4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae1d499...7667903. Read the comment docs.

Set node engine to >=10

closes elastic#359
@nickofthyme nickofthyme force-pushed the build/downgrade-node branch from 2d85012 to 7667903 Compare August 29, 2019 21:15
@markov00 markov00 merged commit 7fcd98c into elastic:master Aug 30, 2019
@markov00 markov00 mentioned this pull request Aug 30, 2019
markov00 pushed a commit that referenced this pull request Aug 30, 2019
## [11.1.2](v11.1.1...v11.1.2) (2019-08-30)

### Bug Fixes

* **engines:** update node engine ([#363](#363)) ([7fcd98c](7fcd98c)), closes [#359](#359)
@markov00
Copy link
Member

🎉 This PR is included in version 11.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Aug 30, 2019
@nickofthyme nickofthyme deleted the build/downgrade-node branch August 30, 2019 13:00
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Issue released publicly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

package.json "engine" is too restrictive
3 participants