fix(crosshair): limit the width of the cursor band on edges #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the xDomain doesn't cover a full interval on the min or max edges, the crosshair is drawn outside the chart. This commit will fix that behaviour limiting the cursor band width and position to be always inside the chart
markov00
added
bug
Codecov Report
@@ Coverage Diff @@
## master #353 +/- ##
=========================================
+ Coverage 98.29% 98.3% +<.01%
=========================================
Files 38 38
Lines 2753 2765 +12
Branches 648 652 +4
=========================================
+ Hits 2706 2718 +12
Misses 43 43
Partials 4 4
Continue to review full report at Codecov.
|
nickofthyme
reviewed
Aug 27, 2019
nickofthyme
approved these changes
Aug 27, 2019
There was a problem hiding this comment.
Tested locally looks good.
I Noticed issue that is also in master #354
|
🎉 This PR is included in version 11.0.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
## [11.0.4](elastic/elastic-charts@v11.0.3...v11.0.4) (2019-08-27) ### Bug Fixes * **crosshair:** limit the width of the cursor band on edges ([opensearch-project#353](elastic/elastic-charts#353)) ([7ab5211](elastic/elastic-charts@7ab5211)), closes [opensearch-project#352](elastic/elastic-charts#352)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If the xDomain doesn't cover a full interval on the min or max edges, the crosshair is drawn outside the chart as shown in the screenshot.
This commit will fix that behaviour limiting the cursor band width and position to be
always inside the chart
fix #352
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.src/index.ts(and stories only import from../srcexcept for test data & storybook)[ ] Proper documentation or storybook story was added for features that require explanation or tutorials