Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hide tooltip when hover over lines #339

Merged
merged 3 commits into from
Aug 22, 2019

Conversation

markov00
Copy link
Member

@markov00 markov00 commented Aug 22, 2019

Summary

This PR adds the possibility to hide the tooltip when hovering over a line annotation.
It adds a new property for the <LineAnnotation /> component called hideLinesTooltips.

Aug-22-2019 15-04-18

NOTE
this works correctly with horizontal charts (0 or 180 degrees) but doesn't hide the tooltip for 90,-90 degree rotated charts. That because there is an issue on detecting the mouse hover for the marker in those cases.
I'd like to merge this anyway so TSVB can have it in for 7.4

fix #324

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

  • [ ] Any consumer-facing exports were added to src/index.ts (and stories only import from ../src except for test data & storybook)
  • This was checked for cross-browser compatibility, including a check against IE11
  • Proper documentation or storybook story was added for features that require explanation or tutorials
  • Unit tests were updated or added to match the most common scenarios
  • Each commit follows the convention

This commit add a new prop for the line annotation to disable the tooltip when hovering over the
line

fix elastic#324
@markov00 markov00 added enhancement New feature or request :interactions Interactions related issue labels Aug 22, 2019
@markov00 markov00 requested a review from nickofthyme August 22, 2019 13:25
@codecov-io
Copy link

codecov-io commented Aug 22, 2019

Codecov Report

Merging #339 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #339      +/-   ##
==========================================
+ Coverage   98.51%   98.51%   +<.01%     
==========================================
  Files          38       38              
  Lines        2691     2692       +1     
  Branches      635      622      -13     
==========================================
+ Hits         2651     2652       +1     
  Misses         37       37              
  Partials        3        3
Impacted Files Coverage Δ
src/chart_types/xy_chart/utils/specs.ts 100% <ø> (ø) ⬆️
...art_types/xy_chart/annotations/annotation_utils.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e94dab9...8f12051. Read the comment docs.

Copy link
Collaborator

@nickofthyme nickofthyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing locally, looks good!

@markov00 markov00 merged commit bef1fc7 into elastic:master Aug 22, 2019
markov00 pushed a commit that referenced this pull request Aug 22, 2019
# [10.1.0](v10.0.1...v10.1.0) (2019-08-22)

### Features

* hide tooltip when over line annotation ([#339](#339)) ([bef1fc7](bef1fc7)), closes [#324](#324)
@markov00
Copy link
Member Author

🎉 This PR is included in version 10.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Aug 22, 2019
@markov00 markov00 deleted the fix_annotation_tooltips branch November 25, 2020 11:45
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request :interactions Interactions related issue released Issue released publicly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable tooltip on annotation line
3 participants