fix(axis): limit chart dimensions to avoid axis labels overflow #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #314 +/- ##
==========================================
+ Coverage 98.04% 98.04% +<.01%
==========================================
Files 37 37
Lines 2714 2715 +1
Branches 642 620 -22
==========================================
+ Hits 2661 2662 +1
Misses 48 48
Partials 5 5
Continue to review full report at Codecov.
|
55 tasks
nickofthyme
approved these changes
Aug 15, 2019
markov00
pushed a commit
that referenced
this pull request
Aug 16, 2019
## [9.1.1](v9.1.0...v9.1.1) (2019-08-16) ### Bug Fixes * **axis:** limit chart dimensions to avoid axis labels overflow ([#314](#314)) ([5751ce0](5751ce0))
|
🎉 This PR is included in version 9.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
7 tasks
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
## [9.1.1](elastic/elastic-charts@v9.1.0...v9.1.1) (2019-08-16) ### Bug Fixes * **axis:** limit chart dimensions to avoid axis labels overflow ([opensearch-project#314](elastic/elastic-charts#314)) ([010634d](elastic/elastic-charts@010634d))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR limit the chart dimensions to include any overflowing axis label. It consider label padding, font size, text etc.
from:
to:
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.src/index.ts(and stories only import from../srcexcept for test data & storybook)