Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: shift bars independently from the specs order #302

Merged
merged 1 commit into from
Aug 12, 2019

Conversation

markov00
Copy link
Member

@markov00 markov00 commented Aug 7, 2019

Summary

Each bar series needs to be shifted depending on how many bars are clustered. We don't have to shift a bar if we previously have computed a set of lines or area series.

fix #301

before
Screenshot 2019-08-07 at 18 16 55

after
Screenshot 2019-08-07 at 18 16 36

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

  • [ ] Any consumer-facing exports were added to src/index.ts (and stories only import from ../src except for test data & storybook)
  • [ ] This was checked for cross-browser compatibility, including a check against IE11
  • [ ] Proper documentation or storybook story was added for features that require explanation or tutorials
  • Unit tests were updated or added to match the most common scenarios
  • Each commit follows the convention

Each bar series needs to be shifted depending on how many bars are clustered. We don't have to shift
a bar if we previously have computed a set of lines or area series.
@markov00 markov00 added the bug Something isn't working label Aug 7, 2019
@markov00 markov00 requested a review from nickofthyme August 7, 2019 16:17
@codecov-io
Copy link

Codecov Report

Merging #302 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #302      +/-   ##
==========================================
+ Coverage   98.17%   98.17%   +<.01%     
==========================================
  Files          37       37              
  Lines        2682     2688       +6     
  Branches      632      619      -13     
==========================================
+ Hits         2633     2639       +6     
  Misses         44       44              
  Partials        5        5
Impacted Files Coverage Δ
src/chart_types/xy_chart/store/utils.ts 96.7% <100%> (+0.02%) ⬆️
src/chart_types/xy_chart/legend/legend.ts 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d10751...2f64178. Read the comment docs.

Copy link
Collaborator

@nickofthyme nickofthyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, LGTM 🚢

@markov00 markov00 merged commit 1cd934d into elastic:master Aug 12, 2019
markov00 pushed a commit that referenced this pull request Aug 12, 2019
## [9.0.2](v9.0.1...v9.0.2) (2019-08-12)

### Bug Fixes

* shift bars independently from the specs order ([#302](#302)) ([1cd934d](1cd934d))
@markov00
Copy link
Member Author

🎉 This PR is included in version 9.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Aug 12, 2019
@markov00 markov00 deleted the fix-bar-offset branch November 25, 2020 11:44
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Feb 10, 2022
## [9.0.2](elastic/elastic-charts@v9.0.1...v9.0.2) (2019-08-12)

### Bug Fixes

* shift bars independently from the specs order ([opensearch-project#302](elastic/elastic-charts#302)) ([a6a5eab](elastic/elastic-charts@a6a5eab))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released Issue released publicly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BarSeries shifted depending on the spec ordering
3 participants