Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotation tooltip position #297

Open
2 tasks done
Tracked by #615
markov00 opened this issue Aug 6, 2019 · 4 comments
Open
2 tasks done
Tracked by #615

Annotation tooltip position #297

markov00 opened this issue Aug 6, 2019 · 4 comments
Labels
enhancement New feature or request :tooltip Related to hover tooltip

Comments

@markov00
Copy link
Member

markov00 commented Aug 6, 2019

Is your feature request related to a problem? Please describe.
The current implementation place the annotation tooltip, to the left or to the right of the annotation area (if it's a rectangle) or place it just in the middle for a line annotation.
With that approach, the tooltip can sometime overlap with the current tooltip, or be shown in some weird places

Screenshot 2019-08-06 at 18 33 38

Screenshot 2019-08-06 at 18 51 03

Screenshot 2019-08-06 at 18 35 02

Describe the solution you'd like
I'd like to check if we can move that tooltip to a proper place.

Describe alternatives you've considered
Possible solutions:

  • if a data tooltip is already shown, move the tooltip text inside that tooltip (on the header, on on a different row)
  • if no data tooltip is shown, display the tooltip but not stocked with the annotation edge. maybe it's better to have it moving together with the mouse.
  • avoid showing a real tooltip, and displaying the text somewhere else on the chart: on the title? just below, above the axis?

Additional context
The vislib chart incorporate that annotation inside the tooltip header:
Screenshot 2019-08-06 at 19 04 33
Screenshot 2019-08-06 at 19 04 29

TSVB just have line annotation with tooltip on the icon (we also allow use to add line annotation without icons)
Screenshot 2019-08-06 at 19 09 23

Kibana Cross Issues
n/a

Checklist

  • this request is checked against already exist requests
  • every related Kibana issue is listed under Kibana Cross Issues list
  • [ ] kibana cross issue tag is associated to the issue if any kibana cross issue is present`
@markov00 markov00 added enhancement New feature or request :interactions Interactions related issue labels Aug 6, 2019
@markov00
Copy link
Member Author

markov00 commented Aug 6, 2019

cc @cchaos

@cchaos
Copy link
Contributor

cchaos commented Aug 22, 2019

I think that the chart itself should take precedence. Only show the annotation's tooltip if the cursor is not also hovering over part of the chart.

@markov00 markov00 added :tooltip Related to hover tooltip and removed :interactions Interactions related issue labels Mar 26, 2020
@markov00
Copy link
Member Author

@nickofthyme I'm resurrecting this enhancement: now that we have the popperjs is that something that can be handled by that library?

@nickofthyme
Copy link
Collaborator

Yes, you could change the anchor of the annotations tooltip. But I think this looks hideous and is prone for very wide tooltips. I think this should be handled in the tooltip redesign, to incorporate the annotation into the tooltip like visualize currently does. But do it in a better, more customizable way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request :tooltip Related to hover tooltip
Projects
None yet
Development

No branches or pull requests

3 participants