Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tooltip): fix tooltip formatting for rotated charts #285

Merged

Conversation

markov00
Copy link
Member

@markov00 markov00 commented Aug 5, 2019

Summary

When using rotated charts, the used X and Y axis for formatting should be inverted.

fix #273

Screenshot 2019-08-05 at 17 26 04

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

  • [ ] Any consumer-facing exports were added to src/index.ts (and stories only import from ../src except for test data & storybook)
  • [ ] This was checked for cross-browser compatibility, including a check against IE11
  • [ ] Proper documentation or storybook story was added for features that require explanation or tutorials
  • Unit tests were updated or added to match the most common scenarios
  • Each commit follows the convention

When using rotated charts, the used X and Y axis for formatting should be inverted.

fix elastic#273
@markov00 markov00 added :interactions Interactions related issue bug Something isn't working labels Aug 5, 2019
@codecov-io
Copy link

codecov-io commented Aug 5, 2019

Codecov Report

Merging #285 into master will increase coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #285      +/-   ##
==========================================
+ Coverage   98.05%   98.16%   +0.11%     
==========================================
  Files          37       37              
  Lines        2671     2673       +2     
  Branches      613      615       +2     
==========================================
+ Hits         2619     2624       +5     
+ Misses         47       44       -3     
  Partials        5        5
Impacted Files Coverage Δ
src/chart_types/xy_chart/store/chart_state.ts 97.46% <100%> (+0.01%) ⬆️
.../chart_types/xy_chart/crosshair/crosshair_utils.ts 95.83% <0%> (+4.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18edde6...2ed2df4. Read the comment docs.

Copy link
Collaborator

@nickofthyme nickofthyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, looks good to me! 👍

@markov00 markov00 merged commit 651edd1 into elastic:master Aug 5, 2019
@markov00 markov00 deleted the fix_tooltip_formatter_on_rotated_chart branch August 5, 2019 17:34
markov00 pushed a commit that referenced this pull request Aug 5, 2019
## [8.1.8](v8.1.7...v8.1.8) (2019-08-05)

### Bug Fixes

* **tooltip:** fix tooltip formatting for rotated charts ([#285](#285)) ([651edd1](651edd1)), closes [#273](#273)
@markov00
Copy link
Member Author

markov00 commented Aug 5, 2019

🎉 This PR is included in version 8.1.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Aug 5, 2019
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working :interactions Interactions related issue released Issue released publicly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In a rotated chart, the tick formatter doesn't apply to the right axis
3 participants