Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: export GeometryValue so onElementClick callbacks can be typed #272

Merged
merged 1 commit into from
Jul 24, 2019

Conversation

emmacunningham
Copy link
Contributor

Summary

This PR exports GeometryValue so that library consumers can use the type in type annotations (for example, when defining a onElementClick callback).

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

- [ ] This was checked for cross-browser compatibility, including a check against IE11
- [ ] Proper documentation or storybook story was added for features that require explanation or tutorials
- [ ] Unit tests were updated or added to match the most common scenarios

  • Any consumer-facing exports were added to src/index.ts (and stories only import from ../src except for test data & storybook)
  • Each commit follows the convention

Copy link
Member

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emmacunningham emmacunningham changed the title chore: export GeometryValue so onElementClick callbacks can be typed fix: export GeometryValue so onElementClick callbacks can be typed Jul 24, 2019
@emmacunningham emmacunningham merged commit 8ed5d11 into elastic:master Jul 24, 2019
markov00 pushed a commit that referenced this pull request Jul 24, 2019
## [8.1.2](v8.1.1...v8.1.2) (2019-07-24)

### Bug Fixes

* export GeometryValue so onElementClick callbacks can be typed ([#272](#272)) ([8ed5d11](8ed5d11))
@markov00
Copy link
Member

🎉 This PR is included in version 8.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Jul 24, 2019
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Feb 10, 2022
## [8.1.2](elastic/elastic-charts@v8.1.1...v8.1.2) (2019-07-24)

### Bug Fixes

* export GeometryValue so onElementClick callbacks can be typed ([opensearch-project#272](elastic/elastic-charts#272)) ([a6657b5](elastic/elastic-charts@a6657b5))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Issue released publicly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants