-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bar_chart): color overrides #271
feat(bar_chart): color overrides #271
Conversation
Allow user to override colors of given datum based on accessor function elastic#216
I didn't label these changes as breaking because I don't think anyone is using the |
Codecov Report
@@ Coverage Diff @@
## master #271 +/- ##
==========================================
+ Coverage 98.05% 98.05% +<.01%
==========================================
Files 37 37
Lines 2671 2680 +9
Branches 613 615 +2
==========================================
+ Hits 2619 2628 +9
Misses 47 47
Partials 5 5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not already tested locally, but I've left few comments.
I think it's better to specify that as a breaking change to correctly align the semver with the code changes also if no one is using the colorAccessor
@markov00 Could you review this again when you have time? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM!
Remember to add the BREAKING CHANGE footer on the merge commit with the description of the changes.
Thanks!
# [9.0.0](v8.1.8...v9.0.0) (2019-08-05) ### Features * **bar_chart:** color/style override accessor ([#271](#271)) ([7634f5c](7634f5c)), closes [#216](#216) ### BREAKING CHANGES * **bar_chart:** colorAccessors removed from YBasicSeriesSpec (aka for all series) which had acted similarly to a split accessor.
🎉 This PR is included in version 9.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# [9.0.0](elastic/elastic-charts@v8.1.8...v9.0.0) (2019-08-05) ### Features * **bar_chart:** color/style override accessor ([opensearch-project#271](elastic/elastic-charts#271)) ([764f127](elastic/elastic-charts@764f127)), closes [opensearch-project#216](elastic/elastic-charts#216) ### BREAKING CHANGES * **bar_chart:** colorAccessors removed from YBasicSeriesSpec (aka for all series) which had acted similarly to a split accessor.
Summary
Allow user to override colors of given datum based on accessor function.
BREAKING CHANGE: Replace ColorAccessor prop and functionality with StyleAccessor
#216
Checklist