-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update EUI and add autoprefixer #267
Conversation
Codecov Report
@@ Coverage Diff @@
## master #267 +/- ##
=======================================
Coverage 98.05% 98.05%
=======================================
Files 37 37
Lines 2671 2671
Branches 613 628 +15
=======================================
Hits 2619 2619
Misses 47 47
Partials 5 5
Continue to review full report at Codecov.
|
It looks to me like the autoprefixer is working in storybook. 🤔 I changed #root {
background-color: blanchedalmond;
+ transition: transform 1s;
} and the #root {
background-color: blanchedalmond;
-webkit-transition: -webkit-transform 1s;
transition: -webkit-transform 1s;
transition: transform 1s;
transition: transform 1s, -webkit-transform 1s;
} and without the plugin the output is... #root {
background-color: blanchedalmond;
transition: transform 1s;
} Is there something specific that you noticed that it isn't working? |
@nickofthyme so if you open storybook and look a chart with a legend, inspect the legend and find the |
See markov00#3 |
🎉 This PR is included in version 8.1.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
## [8.1.3](elastic/elastic-charts@v8.1.2...v8.1.3) (2019-07-30) ### Bug Fixes * update EUI, storybook and add autoprefixer ([opensearch-project#267](elastic/elastic-charts#267)) ([b2b8f47](elastic/elastic-charts@b2b8f47)), closes [opensearch-project#249](elastic/elastic-charts#249)
Summary
This PR updates EUI to the latest version 12.3.1 fixing the legend shadow problem described in #249
before
after
Test
Change the
playground
background color of#root
to a different color than white on theindex.html
file. Add a set of lines series to have a scrolling legend to notice the effect:Minor issue unsolved:
The PR add the missing
autoprefixer
plugin for postcss to enable prefixing css styles likemask-image
. It works correctly on theplayground
and on built bundle (I've checked the compiled css code and seems that all the required styles are correctly prefixed). The missing task is to add the autoprefixer on storybook: @nickofthyme @emmacunningham or @chandlerprall do you have any idea on what I'm doing wrong here?fix #249
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] Any consumer-facing exports were added tosrc/index.ts
(and stories only import from../src
except for test data & storybook)note:
mask-image
used on the legend shadow is not available in IE11. it gracefully fallback to a legend without that shadow[ ] Proper documentation or storybook story was added for features that require explanation or tutorials[ ] Unit tests were updated or added to match the most common scenarios