Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(theme): merge optional params #256

Merged
merged 1 commit into from
Jul 2, 2019
Merged

fix(theme): merge optional params #256

merged 1 commit into from
Jul 2, 2019

Conversation

nickofthyme
Copy link
Collaborator

fix #253

Summary

Allow the option to merge optional partial params.

Checklist

  • Unit tests were updated or added to match the most common scenarios
  • Each commit follows the convention

@nickofthyme nickofthyme added :styling Styling related issue bug Something isn't working labels Jul 2, 2019
@nickofthyme nickofthyme force-pushed the fix/theme-optionals branch from c079c8e to 14c10c9 Compare July 2, 2019 14:49
@codecov-io
Copy link

codecov-io commented Jul 2, 2019 •
edited
Loading

Codecov Report

Merging #256 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #256      +/-   ##
==========================================
+ Coverage   97.76%   97.76%   +<.01%     
==========================================
  Files          36       36              
  Lines        2636     2641       +5     
  Branches      588      607      +19     
==========================================
+ Hits         2577     2582       +5     
  Misses         52       52              
  Partials        7        7
Impacted Files Coverage Δ
src/lib/utils/commons.ts 100% <100%> (ø) ⬆️
src/lib/themes/theme.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc6640d...14c10c9. Read the comment docs.

markov00
markov00 approved these changes Jul 2, 2019
View reviewed changes
Copy link
Member

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@nickofthyme nickofthyme merged commit 9cd660c into elastic:master Jul 2, 2019
@nickofthyme nickofthyme deleted the fix/theme-optionals branch July 2, 2019 21:36
@nickofthyme nickofthyme mentioned this pull request Jul 2, 2019
Closed
2 tasks
markov00 pushed a commit that referenced this pull request Jul 3, 2019
@semantic-release-bot
chore(release): 7.0.2 [skip ci]
1380651 
## [7.0.2](v7.0.1...v7.0.2) (2019-07-03)

### Bug Fixes

* **theme:** merge optional params ([#256](#256)) ([9cd660c](9cd660c)), closes [#253](#253)
@markov00
Copy link
Member

markov00 commented Jul 3, 2019

🎉 This PR is included in version 7.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Jul 3, 2019
@markov00 markov00 mentioned this pull request Jul 10, 2019
Merged
1 task
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Feb 10, 2022
@semantic-release-bot
chore(release): 7.0.2 [skip ci]
c53b657 
## [7.0.2](elastic/elastic-charts@v7.0.1...v7.0.2) (2019-07-03)

### Bug Fixes

* **theme:** merge optional params ([opensearch-project#256](elastic/elastic-charts#256)) ([1b9bb05](elastic/elastic-charts@1b9bb05)), closes [opensearch-project#253](elastic/elastic-charts#253)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markov00 markov00 markov00 approved these changes

@emmacunningham emmacunningham Awaiting requested review from emmacunningham

@rshen91 rshen91 Awaiting requested review from rshen91

Assignees
No one assigned
Labels
bug Something isn't working released Issue released publicly :styling Styling related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing params on partial theme merge
3 participants
@nickofthyme @codecov-io @markov00