fix(legend): avoid expanding label on click #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #209 +/- ##
======================================
Coverage 97.4% 97.4%
======================================
Files 35 35
Lines 2120 2120
Branches 315 315
======================================
Hits 2065 2065
Misses 48 48
Partials 7 7Continue to review full report at Codecov.
|
markov00
pushed a commit
that referenced
this pull request
May 20, 2019
## [4.2.3](v4.2.2...v4.2.3) (2019-05-20) ### Bug Fixes * **legend:** avoid expanding label on click ([#209](#209)) ([22cad8e](22cad8e))
|
🎉 This PR is included in version 4.2.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
## [4.2.3](elastic/elastic-charts@v4.2.2...v4.2.3) (2019-05-20) ### Bug Fixes * **legend:** avoid expanding label on click ([opensearch-project#209](elastic/elastic-charts#209)) ([763fd69](elastic/elastic-charts@763fd69))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The version
4.2.2has introduced a bug on the rendering of the legend when the eye button is clicked as displayed in the gif.This PR fix that issue specifying the grow parameter into the title element.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] Any consumer-facing exports were added tosrc/index.ts(and stories only import from../srcexcept for test data & storybook)[ ] Proper documentation or storybook story was added for features that require explanation or tutorials[ ] Unit tests were updated or added to match the most common scenarios