fix(bars): remove border visibility based on bar width #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit will disable the automatic removal of a border for narrow bars. We let the user/developer decide if the right size of the bar border width. fix elastic#189
Codecov Report
@@ Coverage Diff @@
## master #192 +/- ##
=========================================
Coverage ? 96.99%
=========================================
Files ? 36
Lines ? 1861
Branches ? 260
=========================================
Hits ? 1805
Misses ? 48
Partials ? 8Continue to review full report at Codecov.
|
emmacunningham
approved these changes
Apr 24, 2019
|
🎉 This PR is included in version 3.11.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
## [3.11.4](elastic/elastic-charts@v3.11.3...v3.11.4) (2019-04-26) ### Bug Fixes * **bars:** remove border visibility based on bar width ([opensearch-project#192](elastic/elastic-charts#192)) ([6d41269](elastic/elastic-charts@6d41269)), closes [opensearch-project#189](elastic/elastic-charts#189)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR will disable the automatic removal of a border for narrow bars. We let the
user/developer decide the right size of the bar border width.
fix #189
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.