fix: apply transform.x to area & line geometries #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #172 +/- ##
=======================================
Coverage 96.62% 96.62%
=======================================
Files 36 36
Lines 1867 1867
Branches 251 251
=======================================
Hits 1804 1804
Misses 54 54
Partials 9 9
Continue to review full report at Codecov.
|
markov00
pushed a commit
that referenced
this pull request
Apr 16, 2019
## [3.11.1](v3.11.0...v3.11.1) (2019-04-16) ### Bug Fixes * apply transform.x to area & line geometries ([#172](#172)) ([da4f07f](da4f07f))
|
🎉 This PR is included in version 3.11.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
## [3.11.1](elastic/elastic-charts@v3.11.0...v3.11.1) (2019-04-16) ### Bug Fixes * apply transform.x to area & line geometries ([opensearch-project#172](elastic/elastic-charts#172)) ([55b920f](elastic/elastic-charts@55b920f))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There were discrepancies between the props applied to animated elements and non-animated elements. When we disabled animation across the board, this discrepancy surface issues with the non-animated elements not having the correct transform.x applied, leading to misaligned lines & points in area and line series:
This PR applies the transform to the non-animated elements as well, resolving the alignment issues:
We also move this transform into the build props functions to require consistency in handling these values regardless of animation.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.