fix(heatmap): labels visibility regression #1549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markov00
added
:chart
nickofthyme
approved these changes
Jan 14, 2022
nickofthyme
pushed a commit
that referenced
this pull request
Jan 14, 2022
# [43.0.0](v42.1.0...v43.0.0) (2022-01-14) ### Bug Fixes * **heatmap:** labels visibility regression ([#1549](#1549)) ([067189d](067189d)) * **xy:** switch default timezone to `local` ([#1544](#1544)) ([1233e69](1233e69)) ### BREAKING CHANGES * **xy:** The time axis labels of a time-series chart configured without the timeZone prop are now rendering the labels with the local browser timezone instead of UTC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a regression introduced in #1406 where the hidden labels of a heatmap are always shown.
Caused by the removal of this line https://github.com/elastic/elastic-charts/pull/1406/files#diff-c86d69bd8091ee89ee7ab00cab8dc37754a1c7072da64fc3484b0d5b5aeb1734L70
Will fix the issues listed in elastic/kibana#121593
Checklist
:xy,:partition):interactions,:axis)