Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color contrast on dark theme show invisible link labels #1499

Closed
nickofthyme opened this issue Nov 22, 2021 · 0 comments · Fixed by #1402
Closed

Color contrast on dark theme show invisible link labels #1499

nickofthyme opened this issue Nov 22, 2021 · 0 comments · Fixed by #1402
Labels
bug Something isn't working Impact:Medium :partition Partition/PieChart/Donut/Sunburst/Treemap chart related :styling Styling related issue

Comments

@nickofthyme
Copy link
Collaborator

Describe the bug
When using the default background color on the dark theme, or black background, the linkLabel on a partition chart should be white or at least visible.

image
photo link

To Reproduce
Steps to reproduce the behavior:

  1. Go to 24_linked_label.story.tsx
  2. Apply no textColor to the linkLabel so it uses the default value
  3. Change theme to dark (not eui-dark)
  4. Notice the color contrast logic is bad rendering invisible (black) link labels
  5. Changing the background color to black causes the same result.

Expected behaviour
Color contrast logic returns a sensible color with black background.

@nickofthyme nickofthyme added bug Something isn't working :styling Styling related issue :partition Partition/PieChart/Donut/Sunburst/Treemap chart related labels Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Impact:Medium :partition Partition/PieChart/Donut/Sunburst/Treemap chart related :styling Styling related issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants