fix(build): fix dependencies for kibana integration #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #146 +/- ##
======================================
Coverage 92.9% 92.9%
======================================
Files 33 33
Lines 1495 1495
Branches 166 166
======================================
Hits 1389 1389
Misses 92 92
Partials 14 14Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 3.5.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
## [3.5.1](elastic/elastic-charts@v3.5.0...v3.5.1) (2019-04-02) ### Bug Fixes * **build:** fix dependencies for kibana integration ([opensearch-project#146](elastic/elastic-charts#146)) ([acbf02c](elastic/elastic-charts@acbf02c)), closes [opensearch-project#145](elastic/elastic-charts#145)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix #145
Kibana CI run a type check against the libs imported. We were missing two types, that are not directly exported by the chart package but are subject to typecheck by kibana.
I've moved those dev dependencies to dependencies.
I've also updated the
EUIdependency and fixed the rightreact-konvaversion.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Proper documentation or storybook story was added for features that require explanation or tutorials[ ] Unit tests were updated or added to match the most common scenarios