Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[legend] top and bottom legend position doesn't work well with new truncate setting #1312

Closed
mbondyra opened this issue Aug 19, 2021 · 2 comments · Fixed by #1316
Closed
Assignees
Labels
enhancement New feature or request :legend Legend related issue released Issue released publicly :xy Bar/Line/Area chart related

Comments

@mbondyra
Copy link
Contributor

mbondyra commented Aug 19, 2021

Recently we added an option to truncate the legend in all Visualize, TSVB and Lens editors. It means that the user can

  • choose not to truncate their legend at all
  • truncate their legend items between 1 to 5 lines

When user chooses a legend position top or bottom, the space taken by the legend is around 1.5 lines. Which was fine before, because the shade effect indicated that space is scrollable. I think it's fine for 1 line or not-truncated line, but as we give an option to truncate from 1 to 5 lines, maybe we could in these cases expand this space and show full truncated strings.

Screenshot 2021-08-19 at 11 12 02

Aug-19-2021.11-18-13.1.mp4
@mbondyra mbondyra added the enhancement New feature or request label Aug 19, 2021
@markov00 markov00 added :legend Legend related issue :xy Bar/Line/Area chart related labels Aug 19, 2021
@nickofthyme
Copy link
Collaborator

Yeah it seems that with a single value, like you show, the grid styles are not ideal. We could use a single row when there is only one value which would fix this singular case.

Are you thinking there is also an issue when there are multiple items in the legend? In such a case what would your solution be?

@nickofthyme
Copy link
Collaborator

🎉 This issue has been resolved in version 34.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nickofthyme nickofthyme added the released Issue released publicly label Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request :legend Legend related issue released Issue released publicly :xy Bar/Line/Area chart related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants