Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strengthen the OrdinalDomain type #1271

Open
markov00 opened this issue Jul 27, 2021 · 0 comments
Open

Strengthen the OrdinalDomain type #1271

markov00 opened this issue Jul 27, 2021 · 0 comments
Labels
API Changes the external API types code quality :heatmap Heatmap/Swimlane chart related issue Impact:Medium :xy Bar/Line/Area chart related

Comments

@markov00
Copy link
Member

Describe the bug
From a conversation in #1253 (comment) we can improve the current OrdinalDomain type from (string|number)[] to string[] | number[] as described in the comments

This will have some repercussion on both the Heatmap and the XY charts and the public APIs
@markov00 markov00 added :xy Bar/Line/Area chart related :heatmap Heatmap/Swimlane chart related issue API Changes the external API types code quality labels Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API Changes the external API types code quality :heatmap Heatmap/Swimlane chart related issue Impact:Medium :xy Bar/Line/Area chart related
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@markov00