fix(brushing): enable mouseup event outside chart element #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now add the mouseup listener on the window element at the mousedown event and we remove it after the brush is end. We also disabled the tooltip when brushing. fix elastic#119
Codecov Report
@@ Coverage Diff @@
## master #120 +/- ##
==========================================
+ Coverage 90.41% 90.44% +0.03%
==========================================
Files 31 31
Lines 1439 1445 +6
Branches 161 161
==========================================
+ Hits 1301 1307 +6
Misses 125 125
Partials 13 13
Continue to review full report at Codecov.
|
emmacunningham
approved these changes
Mar 25, 2019
|
🎉 This PR is included in version 3.4.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
## [3.4.1](elastic/elastic-charts@v3.4.0...v3.4.1) (2019-03-26) ### Bug Fixes * **brushing:** enable mouseup event outside chart element ([opensearch-project#120](elastic/elastic-charts#120)) ([9a84aaa](elastic/elastic-charts@9a84aaa)), closes [opensearch-project#119](elastic/elastic-charts#119)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR add the mouseup listener on the window element at the mousedown event for bushing.
we remove it after the brush is end.
We also disabled the tooltip when brushing.
fix #119
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.