fix(theme): restore original point radius values (#276)

elastic · Aug 1, 2019 · 16f789a · 16f789a
1 parent 8de3818
commit 16f789a
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 17 deletions.
diff --git a/src/chart_types/xy_chart/store/utils.test.ts b/src/chart_types/xy_chart/store/utils.test.ts
@@ -779,8 +779,8 @@ describe('Chart State utils', () => {
         visible: true,
         fill: 'green', // the override strokeWidth
         opacity: 1,
-        radius: 4,
-        strokeWidth: 0,
+        radius: 1,
+        strokeWidth: 0.5,
       });
     });
     test('can compute area geometries with custom style', () => {
@@ -868,11 +868,11 @@ describe('Chart State utils', () => {
         opacity: 1,
       });
       expect(geometries.geometries.areas[0].seriesPointStyle).toEqual({
-        visible: true,
+        visible: false,
         fill: 'point-fill-custom-color', // the override strokeWidth
         opacity: 1,
-        radius: 4,
-        strokeWidth: 0,
+        radius: 1,
+        strokeWidth: 0.5,
       });
     });
     test('can compute bars geometries counts', () => {

diff --git a/src/utils/themes/dark_theme.ts b/src/utils/themes/dark_theme.ts
@@ -19,24 +19,26 @@ export const DARK_THEME: Theme = {
     },
     point: {
       visible: true,
-      strokeWidth: 0,
+      strokeWidth: 0.5,
+      fill: 'white',
       radius: 1,
       opacity: 1,
     },
   },
   areaSeriesStyle: {
     area: {
       visible: true,
-      opacity: 1,
+      opacity: 0.8,
     },
     line: {
       visible: true,
-      strokeWidth: 1,
+      strokeWidth: 1.5,
       opacity: 1,
     },
     point: {
-      visible: true,
-      strokeWidth: 0,
+      visible: false,
+      fill: 'white',
+      strokeWidth: 0.5,
       radius: 1,
       opacity: 1,
     },

diff --git a/src/utils/themes/light_theme.ts b/src/utils/themes/light_theme.ts
@@ -19,25 +19,27 @@ export const LIGHT_THEME: Theme = {
     },
     point: {
       visible: true,
-      strokeWidth: 0,
-      radius: 4,
+      strokeWidth: 0.5,
+      fill: 'white',
+      radius: 1,
       opacity: 1,
     },
   },
   areaSeriesStyle: {
     area: {
       visible: true,
-      opacity: 1,
+      opacity: 0.8,
     },
     line: {
       visible: true,
-      strokeWidth: 1,
+      strokeWidth: 1.5,
       opacity: 1,
     },
     point: {
-      visible: true,
-      strokeWidth: 0,
-      radius: 4,
+      visible: false,
+      fill: 'white',
+      strokeWidth: 0.5,
+      radius: 1,
       opacity: 1,
     },
   },

diff --git a/src/utils/themes/theme.test.ts b/src/utils/themes/theme.test.ts
@@ -155,6 +155,7 @@ describe('Theme', () => {
           opacity: 1,
         },
         point: {
+          fill: 'white',
           radius: 314571,
           stroke: 'elastic_charts',
           strokeWidth: 314571,
@@ -189,6 +190,7 @@ describe('Theme', () => {
           opacity: 1,
         },
         point: {
+          fill: 'white',
           visible: true,
           radius: 314571,
           stroke: 'elastic_charts',