Ensure unique ID for dynamic variable replacement.

[blakerouse]

What does this PR do?

This updates the ID of an input to concat the current ID with the unique ID of the variable context from the dynamic provided that provided the replacement.

The original ID is moved to original_id and the new id is placed on the input.

Why is it important?

Ensures that when a variable substitution is performed for an input definition duplicate of that input results in a unique ID for that newly defined input.

Checklist

• My code follows the style guidelines of this project
• I have commented my code, particularly in hard-to-understand areas
• [ ] I have made corresponding changes to the documentation
• [ ] I have made corresponding change to the default configuration files
• I have added tests that prove my fix is effective or that my feature works
• I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

• Closes Input IDs are not unique at runtime when dynamic providers are used #1751

[mergify]

This pull request does not have a backport label. Could you fix it @blakerouse? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

• backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

[sonarqubecloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
8.0% Duplication

[elasticmachine]

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Start Time: 2022-12-01T21:07:31.201+0000

• Duration: 18 min 18 sec

Test stats 🧪

Test	Results
Failed	0
Passed	4661
Skipped	13
Total	4674

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

• /test : Re-trigger the build.

• /package : Generate the packages.

• run integration tests : Run the Elastic Agent Integration tests.

• run end-to-end tests : Generate the packages and run the E2E Tests.

• run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

[elasticmachine]

🌐 Coverage report

Name	Metrics % (covered/total)	Diff
Packages	98.333% (59/60)	👍
Files	69.082% (143/207)	👍
Classes	69.133% (271/392)	👍
Methods	53.958% (818/1516)	👍 0.096
Lines	39.083% (8841/22621)	👍 0.059
Conditionals	100.0% (0/0)	💚

[cmacknz]

The changes here themselves look good, but I don't see any new tests added. Did the existing tests reproduce this problem with the additional ID field? How did we verify this? Do we need to follow up and add a regression test for this?

[blakerouse]

@cmacknz The existing tests where modified to cover it. So it's fully covered and if a regression happens the tests would catch it.