Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 Configuration Reloading Checklist #1056

Closed
4 of 6 tasks
michalpristas opened this issue Aug 31, 2022 · 3 comments
Closed
4 of 6 tasks

V2 Configuration Reloading Checklist #1056

michalpristas opened this issue Aug 31, 2022 · 3 comments
Assignees
Labels
estimation:Week Task that represents a week of work. Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team V2-Architecture v8.6.0

Comments

@michalpristas
Copy link
Contributor

michalpristas commented Aug 31, 2022

Before merging V2 branch we need to make sure other functionality introduced/used in previous model works as expected today:

  • reloading proxy settings, all clients are using desired proxy config
  • reloading download config, upgrade downloads agent from desired path
  • reloading monitoring config, when config changes monitoring is shut down/altered
  • reloading log level, beats and agent are unable to reload log level on the fly make sure it still works
  • reloading artifact config is still functional (sourceURI, timeouts, drop path)
  • make sure included config files make sense and agent consumes/parses them correctly

These should be verified, in case feature does not work let's create separate issue and link it to this one.

cc @blakerouse

Test 03/Nov/2022

local scenarios passing

Test 01/Nov/2022

🟢 handle source_uri change

🔴 handle proxy change

no UI option

🔴 handle artifact config change

no UI option

Test 20/Oct/2022

Not Working:

🔴 reloading log level

always injecting debug, as per spec, linked to #221

🔴 handle source_uri change

not included, should be in next main merge

🔴 handle proxy change

not included, should be in next main merge

🔴 handle artifact config change

not included, should be in next main merge

@michalpristas michalpristas added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team V2-Architecture labels Aug 31, 2022
@michalpristas
Copy link
Contributor Author

i will make sure reloading monitoring config, when config changes monitoring is shut down/altered works when i'm done with #954

@cmacknz cmacknz changed the title V2 checklist V2 Configuration Reloading Checklist Aug 31, 2022
@michalpristas michalpristas added the estimation:Week Task that represents a week of work. label Sep 26, 2022
@michalpristas
Copy link
Contributor Author

updated description with test results I made today

@michalpristas
Copy link
Contributor Author

seems ok so far. i'm closing this in case we face some issues after big main merge we will deal with them separately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
estimation:Week Task that represents a week of work. Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team V2-Architecture v8.6.0
Projects
None yet
Development

No branches or pull requests

2 participants