-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce free-form text sections in docs #943
Comments
I've pushed a branch that can be pulled down and viewed with I had to modify the Here, I focused on the hierarchy structure and each usage subpage is a placeholder. The three mockups are viewed under the
cc @webmat |
Thanks for providing that branch to check out. I have to say, the Star Wars ipsum used in the "Autonomous System" page example is far superior to generic lorem ipsum 😂 I hadn't considered splitting out the field reuse info to another sub-page. This is an interesting idea 👍 For now I have a concern that clicking on the main nav link users see in the sidebar leads to an almost empty page. Sidebar link: Right now this page only contains the field set description. Moreover, unless the user is looking at one of the very first field sets alphabetically, they won't see how the sidebar section has expanded (as your Base example shows). Here's two thoughts on how we could address this. Now, and down the line. For now: that top page should add a mini-table of content that lists all sub-pages to that field set. I think we could add this TOC below the field set definition. Down the line, I think this top page could contain (in order):
The initial approach would however have a few drawbacks, until we can add the compact table:
|
Took me a while to realize also that the agent and base static asciidoc was under So I ultimately agree with your approach of putting them under |
Haha I just realized you were actually providing 3 options 🤦 So feedback above was for the way "Base" is laid out. Having the usage doc under the list of fields would hinder discoverability too much, I think. The AS field set is really short and doesn't really show this, but if one thinks of adding usage instructions at the bottom of the "event" field set, then we get a good sense of how far down they would be :-) So I think option 2 (Agent) would strike a great balance for now. This way users clicking the sidebar link would still land exactly on the page they always land on. Then if there's a usage page, they have the sub-page they can visit as well. The only adjustment I'd make is to add the link to the usage page between the description and the field listing, when there's a usage page. Along with option 2, I think for now I would stick to field reuse information being where it is now, at the bottom of the field list. This section is not ideal, but I think extracting it out to a distinct page may make things worse. Bonus point, by not creating a page out of it, we only have to deal with one link to the usage page when appropriate, but not with awkward 1 or 2 line TOCs :-) |
I should have called attention to the usage files under Initially, I had also imagined the usage docs under Agree we will need clear documentation explaining the file structure.
Excellent - this was my preferred choice as well. 😺
OK great. Side note but related to field reuse - I still plan to revisit some of the field reuse improvements discussed previously in #569. |
Closing with the merging of #988 |
Summary
Introduce a concept into the ECS repo which captures extended usage examples. These examples would appear in the ECS documentation as a dedicated page per field set.
Motivation:
Real-world examples are powerful tools to help users better grasp ECS concepts and how users can better map their custom data sources. In addition to the field specifications, ECS also provides guidance on the preferred design patterns for modeling particular events.
A wealth of examples and past discussion is captured in the repo and on Discuss, but not in the ECS docs. Having such examples incorporated into the docs would provide a single, authoritative location. Restructuring could also allow us to include diagrams, code snippets, and other visual aids.
Issues touching on or providing such examples:
Design Proposal:
Refactor the existing
schemas
directoryschemas
directory contains a collection of YAML files and a README.usage
orexample
file.Add a new page dedicated to the free-form usage and examples docs. The page will be nested underneath the field set reference page.
The AsciiDoc generator will be updated to support this refactoring in the docs
To-do:
[discrete]
attribution for field details section headers.[discrete]
will need to be added to the previous ECS version branches to ensure the legacy formatting is retained after changing the chunking level.1
to2
The text was updated successfully, but these errors were encountered: