Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expected locations for url fields in http requests/responses #85

Closed
vbohata opened this issue Aug 15, 2018 · 2 comments
Closed

Expected locations for url fields in http requests/responses #85

vbohata opened this issue Aug 15, 2018 · 2 comments

Comments

@vbohata
Copy link

vbohata commented Aug 15, 2018

The docs says URL can be reused in other prefixes. According to #83 it is actually a top level item. As url can be part of both http request and response (in case of redirects), should not docs mentioned this use case if expected to use the url this way? If not what are correct locations for url objects?

@ruflin
Copy link
Member

ruflin commented Aug 15, 2018

This also ties into the discussion here: #71 If we say all "objects/fields" are reusable we can "indicate" the best places to use them but not document all of them.

If we add it to the http request and response agree that it could be a more straight forward one that would need documentation.

If you add it on the top level or inside each request / response depends on your correlation needs. Do you want to correlate all urls? Put it into the top level field. Only want to correlate responses, use the response url field. If you want both, copy the field also in the top url fields.

@vbohata
Copy link
Author

vbohata commented Aug 15, 2018

OK, thanks.

@vbohata vbohata closed this as completed Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants