Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feedback]: compare changes doesn't work when already viewing the changelog. #184

Open
TinaHeiligers opened this issue Nov 9, 2024 · 2 comments
Assignees
Labels
api-feedback bug Something isn't working

Comments

@TinaHeiligers
Copy link

Was the documentation helpful?

Yes

What documentation page is affected

https://www.elastic.co/docs/api/doc/serverless/compare/79ff5f69-7a76-436d-b09d-de5cfe42eb77
Similarly, for previous release dates: https://www.elastic.co/docs/api/doc/serverless/compare/1853d895-f245-46a4-b2a8-e51e589746af

Description

Selecting a version responds with 422.
Image

@TinaHeiligers TinaHeiligers added api-feedback bug Something isn't working labels Nov 9, 2024
@lcawl lcawl self-assigned this Nov 13, 2024
@lcawl
Copy link
Contributor

lcawl commented Nov 13, 2024

Thanks, I can recreate the problem too. I will follow up with Bump.sh

@paulRbr
Copy link

paulRbr commented Nov 13, 2024

Hi @lcawl,

We use a POST request for this action on the docs @bump.sh, I believe that your proxy is blocking POST requests your proxy doesn't seem to send the necessary X-Forwarded-Host header. Could you check if that's something that can be adapted on your side?

Let me know if you have any questions!

EDIT: I've checked in our logs and can see there's a mismatch origin host which makes us respond with a 422 error, so the proxy sends the POST request correctly to our servers but it seems to lack some necessary headers so we can't verify the original host header sent by the client. Notably, we would need the proxy to add those headers:

  • X-Forwarded-Proto 'https'
  • X-Forwarded-Port 433
  • X-Forwarded-Host 'https://www.elastic.co'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-feedback bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants