Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding fieldPath to CRD validation rules removes the whole API group doc #94

Open
1 task
pmalek opened this issue Sep 19, 2024 · 3 comments
Open
1 task

Comments

@pmalek
Copy link

pmalek commented Sep 19, 2024

Problem statement

controller-tools 0.16.0 introduced support for fieldPath in CRD validation rules: kubernetes-sigs/controller-tools#932

When adding those code markers crd-ref-docs removes the whole API group documentation for some reason.

Acceptance criteria

  • As a user I can use fieldPath for my CRD validation rules and get documentation generated using crd-ref-docs.
@pmalek
Copy link
Author

pmalek commented Jan 8, 2025

Just tested bumping sigs.k8s.io/controller-tools to v0.17.0 and it seems to do the trick.

Any chance we can get #102 merged and then a bump to 0.17.0?

@thbkrkr can you help here?

@thbkrkr
Copy link
Contributor

thbkrkr commented Jan 8, 2025

sigs.k8s.io/controller-tools has been updated to v0.17.0 in:

@pmalek
Copy link
Author

pmalek commented Jan 8, 2025

sigs.k8s.io/controller-tools has been updated to v0.17.0 in:

Thanks! Any chance to release 0.1.1 with these changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants