Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Logs to be Added in All Connectors #2299

Open
khushbu-elastic opened this issue Mar 26, 2024 · 1 comment
Open

Missing Logs to be Added in All Connectors #2299

khushbu-elastic opened this issue Mar 26, 2024 · 1 comment

Comments

@khushbu-elastic
Copy link

Problem Description

Logs are missing in several/ all connectors that your team has built.
Here are some very simple levels of logging we may need to add:

  • what is the path we make a request to in the 3rd party + parameters
  • Log the error response (not just code) from the 3rd party.
  • Info level logs when we change the type of data you are syncing (eg in GH when switch btw PRs and issues)
  • Info/debug logs each time a significant code path fork occurs (like a large if/else block, indicate which path is taken)

Proposed Solution

Adding the above mentioned logs to the connectors

CC: @DianaJourdan

@artem-shelkovnikov
Copy link
Member

Ideally start with 1 connector per PR and share full logs for run before/after both in DEBUG and INFO logs. We'll iterate on a couple connectors and adjust the guidelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants