Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Asset Inventory] Cloudbeat panics if SNS topic fetching returns error #2640

Closed
moukoublen opened this issue Oct 24, 2024 · 0 comments · Fixed by #2784
Closed

[Asset Inventory] Cloudbeat panics if SNS topic fetching returns error #2640

moukoublen opened this issue Oct 24, 2024 · 0 comments · Fixed by #2784
Assignees
@jeniawhite
Labels
bug Something isn't working Team:Cloud Security Cloud Security team related

Comments

@moukoublen
Copy link
Member

moukoublen commented Oct 24, 2024 •
edited
Loading

Describe the bug
When

The problem exists in code: here and here.

While handling ListTopics and returning an error, a break/continue is required and missing. Thus the code attempts to access parts of the nil pointer and panics.

The fix is low-effort and could be backported to the next 8.16.0 BC.

Image
@moukoublen moukoublen added bug Something isn't working Team:Cloud Security Cloud Security team related labels Oct 24, 2024
@jeniawhite jeniawhite self-assigned this Nov 27, 2024
@jeniawhite jeniawhite mentioned this issue Nov 28, 2024
Merged
5 tasks
@mergify mergify bot mentioned this issue Dec 1, 2024
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeniawhite jeniawhite

Labels
bug Something isn't working Team:Cloud Security Cloud Security team related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix SNS topics fetch panics on errors jeniawhite/cloudbeat
2 participants
@moukoublen @jeniawhite