Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Helm] Updated pod labels to include all standard k8s labels and updated hel… #8278

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jimmybchopps
Copy link

  • Updated labels to use common kubernetes labels on pods (previously it was only on statefulset and several were missing from pod) to increase traceability throughout the application.
  • Added helm unittests to check for updated labels in addition to the podLabels that can be provided via values.yaml file
  • Ran make helm-test to validate changes and updates to test

@jimmybchopps jimmybchopps changed the title Updated pod labels to include all standard k8s labels and updated hel… [helm] Updated pod labels to include all standard k8s labels and updated hel… Nov 29, 2024
@botelastic botelastic bot added the triage label Nov 29, 2024
@jimmybchopps jimmybchopps changed the title [helm] Updated pod labels to include all standard k8s labels and updated hel… [Helm] Updated pod labels to include all standard k8s labels and updated hel… Nov 29, 2024
@thbkrkr thbkrkr added :helm-charts >enhancement Enhancement of existing functionality labels Dec 11, 2024
@botelastic botelastic bot removed the triage label Dec 11, 2024
@thbkrkr
Copy link
Contributor

thbkrkr commented Dec 11, 2024

We use the operator Helm chart to generate the YAML manifests that allow the operator to be installed without Helm.

Check https://www.elastic.co/guide/en/cloud-on-k8s/current/k8s-installing-eck.html:

# Install without Helm
kubectl create -f https://download.elastic.co/downloads/eck/2.15.0/crds.yaml
kubectl apply -f https://download.elastic.co/downloads/eck/2.15.0/operator.yaml // <-- operator YAML manifest

You can call the generation via make generate. The operator YAML manifest is then written in ./config/operator.yaml.

One issue with your change is that we end up with "Helm" bits in this YAML manifest.

> make generate
> cat config/operator.yaml | grep -i helm
        helm.sh/chart: eck-operator-2.16.0-SNAPSHOT
        app.kubernetes.io/managed-by: Helm

@jimmybchopps
Copy link
Author

@thbkrkr I see, I'll rework the solution and test it out using make generate to make sure this is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>enhancement Enhancement of existing functionality :helm-charts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants