Add support for defining dnsPolicy and dnsConfig options for ECK operator statefulset #7999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thbkrkr
added
>feature
naemono
requested changes
Nov 22, 2024
There was a problem hiding this comment.
Really sorry for the delays in getting this reviewed. I have a question about why we are making decisions on linking dnsPolicy and dnsConfig? And what if we set hostNetwork: true, and dnsPolicy: "something-else"? It explicitly sets dnsPolicy to clusterfirstWithHostNet.
|
Thank you for this contribution! Since there hasn’t been recent activity, I’ll adopt this PR to complete it and get it merged. Your work will be preserved and credited. |
thbkrkr
force-pushed
the
operator-dns-config
branch
from
e26e6b7 to
795dab6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to the statefulset template for defining
dnsPolicyanddnsConfigoptions.Flow control is designed to both prevent conflicts with the existing hostNetwork option and to only render out these options if they are both defined together.If
hostNetworkis enabled,dnsPolicydefaults toClusterFirstWithHostNetunless explicitly set.Both new options have been documented with examples in
values.yaml.