Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support declarative plugin management starting Elasticsearch 7.16 #5145

Open
sebgl opened this issue Dec 8, 2021 · 3 comments
Open

Support declarative plugin management starting Elasticsearch 7.16 #5145

sebgl opened this issue Dec 8, 2021 · 3 comments
Labels
>feature Adds or discusses adding a feature to the product

Comments

@sebgl
Copy link
Contributor

sebgl commented Dec 8, 2021

Elasticsearch supports declarative plugin management starting 7.16: elastic/elasticsearch#70219, through an elasticsearch-plugins.yml file (official docs).

I think it would make sense for us to either:

  • document how to rely on that feature by mounting a configmap through the podTemplate spec, rather than documenting our init container method
  • expose that feature in the Elasticsearch CRD (and document it)
@sebgl sebgl added the >feature Adds or discusses adding a feature to the product label Dec 8, 2021
@thbkrkr
Copy link
Contributor

thbkrkr commented Dec 8, 2021

Relates to #3530.

@pebrc
Copy link
Collaborator

pebrc commented Dec 15, 2021

If we wanted to support declarative plugin installation in the CRD we would have to find a solution for older versions of Elasticsearch pre 7.16.

  • we could validate that the version in spec is at least 7.16 when a users specifies plugins
  • we could fall back to init container based installation for earlier versions

More fundamentally, however, I wonder if we really should support this feature first class in the CRD as it encourages to use a sub-optimal way of installing the plugins (at least on K8s if I understand correctly how the new feature works we still have the problem that plugin installation will need to be repeated on each Pod recreation). A custom Docker image still sidesteps the potential issues of repeated installation and avoids installation failures due to network issues.

So maybe adjusting our documentation to illustrate the declarative approach instead would be preferable?

@needleshaped
Copy link

Relates to elastic/elasticsearch#55443

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>feature Adds or discusses adding a feature to the product
Projects
None yet
Development

No branches or pull requests

4 participants