Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not set a default value for the version qualifier #9128

Merged
merged 1 commit into from
Nov 16, 2018

Conversation

ph
Copy link
Contributor

@ph ph commented Nov 16, 2018

Version qualifier should be handled by the release manager and not beats

Version qualifier should be handled by the release manager and not beats
Copy link
Member

@mgreau mgreau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ph ph merged commit 122fb93 into elastic:master Nov 16, 2018
@andrewkroh
Copy link
Member

@ph Is this part of closing out #8384 ? If so I think there are some other changes required like
https://github.com/elastic/beats/blob/master/libbeat/version/helper.go#L34.

@ph
Copy link
Contributor Author

ph commented Nov 17, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants