Update default value for flush.timeout and flush.min_events #7192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checking the code, it seems the default `flush.timeout` is `1s` - https://github.com/elastic/beats/blob/v6.2.4/libbeat/publisher/queue/memqueue/config.go#L14-L18 - instead of `0s` . Change needs some dev review to confirm!
ismael-hasan
changed the title
urso
reviewed
May 29, 2018
libbeat/docs/queueconfig.asciidoc
Outdated
| @@ -74,5 +74,5 @@ The default value is 0. | |||
| Maximum wait time for `flush.min_events` to be fulfilled. If set to 0s, events | |||
| will be immediately available for consumption. | |||
|
|
|||
| The default values is 0s. | |||
| The default values is 1s. | |||
There was a problem hiding this comment.
flush.min_events should default to 2048 as well.
There was a problem hiding this comment.
roger that @urso , changed that as well and corrected a typo (and the title of the issue)
added 2 commits
May 30, 2018 08:07
flush.min_events setting the default to 2048
The default `values` is 1s. -> The default `value` is 1s.
ismael-hasan
changed the title
dedemorton
added
the
needs_backport
urso
approved these changes
Jun 5, 2018
urso
pushed a commit
to urso/beats
that referenced
this pull request
Jun 5, 2018
…7192) * Update default value for flush.timeout Checking the code, it seems the default `flush.timeout` is `1s` - https://github.com/elastic/beats/blob/v6.2.4/libbeat/publisher/queue/memqueue/config.go#L14-L18 - instead of `0s` . Change needs some dev review to confirm! * Updated default value for flush.min_events flush.min_events setting the default to 2048 * Corrected typo The default `values` is 1s. -> The default `value` is 1s. (cherry picked from commit dca6ad8)
urso
added
v6.3.0
and removed
needs_backport
|
Thank you for the doc fix! I did prepare the backport for 6.3. |
ph
pushed a commit
that referenced
this pull request
Jun 5, 2018
* Update default value for flush.timeout Checking the code, it seems the default `flush.timeout` is `1s` - https://github.com/elastic/beats/blob/v6.2.4/libbeat/publisher/queue/memqueue/config.go#L14-L18 - instead of `0s` . Change needs some dev review to confirm! * Updated default value for flush.min_events flush.min_events setting the default to 2048 * Corrected typo The default `values` is 1s. -> The default `value` is 1s. (cherry picked from commit dca6ad8)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…7192) * Update default value for flush.timeout Checking the code, it seems the default `flush.timeout` is `1s` - https://github.com/elastic/beats/blob/v6.2.4/libbeat/publisher/queue/memqueue/config.go#L14-L18 - instead of `0s` . Change needs some dev review to confirm! * Updated default value for flush.min_events flush.min_events setting the default to 2048 * Corrected typo The default `values` is 1s. -> The default `value` is 1s. (cherry picked from commit c617edb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking the code, it seems the default
flush.timeoutis1s- https://github.com/elastic/beats/blob/v6.2.4/libbeat/publisher/queue/memqueue/config.go#L14-L18 - instead of0s. Change needs some dev review to confirm!