Migrate: Log prospector to the input interface #6120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ph
force-pushed
the
refactor/log-prospector-to-input
branch
from
a136d42 to
bbbbba0
Compare
ph
changed the title
10 tasks
ph
force-pushed
the
refactor/type-aliasing-input
branch
from
d027f45 to
0e31dc7
Compare
ph
force-pushed
the
refactor/log-prospector-to-input
branch
2 times, most recently
from
4833141 to
ece1068
Compare
ph
force-pushed
the
refactor/log-prospector-to-input
branch
from
ece1068 to
01d7fb2
Compare
ruflin
reviewed
Jan 25, 2018
filebeat/input/log/input.go
Outdated
| @@ -11,8 +11,8 @@ import ( | |||
|
|
|||
| "github.com/elastic/beats/filebeat/channel" | |||
| "github.com/elastic/beats/filebeat/harvester" | |||
| input "github.com/elastic/beats/filebeat/input" | |||
There was a problem hiding this comment.
Why do you prefix it here with input? It should already be input.
There was a problem hiding this comment.
let me check that, i believe my editor did this change.
ph
force-pushed
the
refactor/log-prospector-to-input
branch
from
01d7fb2 to
d118088
Compare
|
@ruflin rebase and removed the input, not sure about the import, I've never managed the import manually. |
ph
force-pushed
the
refactor/log-prospector-to-input
branch
from
d118088 to
e0c46be
Compare
ph
force-pushed
the
refactor/log-prospector-to-input
branch
from
e0c46be to
9b31bd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
require #6078