Fix ML jobs setup for dynamic modules #5509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exekias
added
bug
Filebeat
Modules from `modules.d` were ignored by both `setup` command and `--setup` flag. Fixes elastic#5504
|
Thanks for finding a solution! I think the approach is good, but one of the tests is failing. |
exekias
force-pushed
the
fix-ml-setup
branch
6 times, most recently
from
6c9950b to
1f29735
Compare
|
Thanks for noticing, kibana is needed to load with |
exekias
added a commit
to exekias/beats
that referenced
this pull request
Nov 6, 2017
* Fix ML jobs setup for dynamic modules Modules from `modules.d` were ignored by both `setup` command and `--setup` flag. Fixes elastic#5504 * Fix test (cherry picked from commit adcd3d0)
exekias
removed
the
needs_backport
exekias
added a commit
to exekias/beats
that referenced
this pull request
Nov 6, 2017
tsg
pushed a commit
that referenced
this pull request
Nov 7, 2017
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
elastic#5518) * Fix ML jobs setup for dynamic modules (elastic#5509) * Fix ML jobs setup for dynamic modules Modules from `modules.d` were ignored by both `setup` command and `--setup` flag. Fixes elastic#5504 * Fix test (cherry picked from commit 70a5ae4) * Update CHANGELOG.asciidoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modules from
modules.dwere ignored by bothsetupcommand and--setupflag.Fixes #5504