Add kubernetes manifests #5349
Merged
Add kubernetes manifests #5349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exekias
added
enhancement
Filebeat
exekias
force-pushed
the
kubernetes-manifests
branch
5 times, most recently
from
d46df15 to
e1a48b8
Compare
|
jenkins package it please |
exekias
force-pushed
the
kubernetes-manifests
branch
7 times, most recently
from
e4498cf to
8e98fe7
Compare
exekias
added
review
and removed
in progress
Import https://github.com/elastic/beats-kubernetes, these manifests deploy filebeat & metricbeat to Kubernetes
exekias
force-pushed
the
kubernetes-manifests
branch
from
5793618 to
6a4f2af
Compare
ruflin
reviewed
Oct 10, 2017
| @@ -149,6 +155,13 @@ python-env: | |||
| @$(PYTHON_ENV)/bin/pip install -q --upgrade pip autopep8 six | |||
|
|
|||
| # Tests if apm works with the current code | |||
| .PHONY: python-env | |||
| .PHONY: test-apm | |||
deploy/kubernetes/.travis/setup.sh
Outdated
| until $( curl --output /dev/null --silent http://localhost:8080 ) || [ $TIMEOUT -eq $TIMEOUT_COUNT ]; do | ||
| echo "Kube is not up yet" | ||
| let TIMEOUT=TIMEOUT+1 | ||
| sleep 20 |
There was a problem hiding this comment.
That would mean in total it could wait up to 800s? Seems like a bit too much. I would probably increase the TIMEOUT_COUNT to a larger number like 300 but just sleep for 1 second each time.
There was a problem hiding this comment.
It normally goes up to ~28 iteration of 40, that leaves around 3 extra minutes for the worst case, is not that much, I could make it more granular if you want, but total timeout time looks good to me as it is, wdyt?
There was a problem hiding this comment.
oh, didn't expect it to take several minutes to setup. Then the total is definitively good :-)
I would probably modify the checks as checking every second does not seem to be much overhead, it makes the tests quicker (in best case 19s ;-) ) and I think it's easier to read for a dev changing the code (personal preference).
deploy/kubernetes/Makefile
Outdated
| @@ -0,0 +1,22 @@ | |||
| ALL = filebeat metricbeat | |||
There was a problem hiding this comment.
Is the space after ALL on purpose?
There was a problem hiding this comment.
No special reason, can change it
exekias
added
the
needs_backport
exekias
force-pushed
the
kubernetes-manifests
branch
from
6a4f2af to
7d62181
Compare
|
pinging @dedemorton on the documentation, let me know what do you think |
exekias
removed
the
needs_backport
exekias
added a commit
to exekias/beats
that referenced
this pull request
Oct 27, 2017
* Add kubernetes manifests Import https://github.com/elastic/beats-kubernetes, these manifests deploy filebeat & metricbeat to Kubernetes * Add travis tests * Add packaging * Add docs * Update CHANGELOG * Fix Makefile * Check k8s health every second (cherry picked from commit 21eefda)
tsg
pushed a commit
that referenced
this pull request
Oct 30, 2017
* Add kubernetes manifests (#5349) * Add kubernetes manifests Import https://github.com/elastic/beats-kubernetes, these manifests deploy filebeat & metricbeat to Kubernetes * Add travis tests * Add packaging * Add docs * Update CHANGELOG * Fix Makefile * Check k8s health every second (cherry picked from commit 21eefda) * Fix chown timing issues on k8s deploy (#5410) It seems to be failing for v1.7.7, this change should fix it * Publish kubernetes manifests in the code (#5418) They will be available for download from github * Update YAML files to current version * Update CHANGELOG.asciidoc
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
* Add kubernetes manifests (elastic#5349) * Add kubernetes manifests Import https://github.com/elastic/beats-kubernetes, these manifests deploy filebeat & metricbeat to Kubernetes * Add travis tests * Add packaging * Add docs * Update CHANGELOG * Fix Makefile * Check k8s health every second (cherry picked from commit d8f2092) * Fix chown timing issues on k8s deploy (elastic#5410) It seems to be failing for v1.7.7, this change should fix it * Publish kubernetes manifests in the code (elastic#5418) They will be available for download from github * Update YAML files to current version * Update CHANGELOG.asciidoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Import https://github.com/elastic/beats-kubernetes, these manifests
deploy filebeat & metricbeat to Kubernetes
Also add documentation about them
Related to #5292