Change index name in the dashboards and index-pattern #4949

monicasarbu · 2017-08-18T14:16:01Z

When loading the dashboards and the index-pattern, you can configure the name of the index under setup.dashboards.index:

$ ./metricbeat setup -E setup.dashboards.directory=_meta/kibana -E setup.dashboards.index=testbeat-* -e

This replaces the index name from the index-pattern and all the dashboards.

This change is done for loading the 5.x and 6.x dashboards.

Note This doesn't work for dashboards containing the Timelion visualizations.

cc-ed @ruflin

monicasarbu · 2017-08-21T11:30:15Z

@ruflin Please let me know if this works for you.

ruflin · 2017-08-22T11:22:43Z

libbeat/dashboards/kibana_loader.go

 	if err != nil {
 		return fmt.Errorf("fail to read index-pattern: %v", err)
 	}

-	return loader.client.ImportJSON(importAPI, params, bytes.NewBuffer(content))
+	var indexContent common.MapStr
+	json.Unmarshal(reader, &indexContent)


Add an error check here?

ruflin · 2017-08-22T12:04:00Z

I tested this and encountered one issues: It seems to work with most dashboards but not the ones that include timelion. There I get the error Visualize: Error: in cell #1: Elasticsearch index not found: metricbeat*. Probably a different thing to overwrite.

@monicasarbu I would be ok to even merge as is and "document" that it will not work with Timelion queries as this is already a huge step forward.

monicasarbu · 2017-08-24T14:56:30Z

As we are planning to redo our dashboards that are based on Timelion, I suggest having support for changing the index name only for the dashboards that are not based on Timelion visualizations.

monicasarbu · 2017-08-24T14:57:39Z

@ruflin I addressed your comments. The PR is ready for review.

ruflin

LGTM. I left you some minor "style" comments. Could you rebase on master?

I didn't test again manually as it seems the last commit was mainly rebase.

ruflin · 2017-08-25T08:22:40Z

libbeat/dashboards/es_loader.go

-	json.Unmarshal([]byte(jsonContent.PanelsJSON), &widgets)
+	err = json.Unmarshal([]byte(jsonContent.PanelsJSON), &widgets)
+	if err != nil {
+		return fmt.Errorf("filt to unmatshal panels content: %v", err)


s/filt/fail/
s/unmatshal/unmarshal/

ruflin · 2017-08-25T08:23:05Z

libbeat/dashboards/es_loader.go

+	var vizContent common.MapStr
+	err = json.Unmarshal(reader, &vizContent)
+	if err != nil {
+		return fmt.Errorf("Failed to unmarshal vizualization content %s: %v", file, err)


We normally have errors that are returned starting lower case.

ruflin · 2017-08-25T08:23:29Z

libbeat/dashboards/es_loader.go

-	json.Unmarshal(reader, &jsonContent)
+	err = json.Unmarshal(reader, &jsonContent)
+	if err != nil {
+		return fmt.Errorf("failt to unmarshal the search content: %v", err)


s/failt/failed/

ruflin · 2017-08-25T08:24:00Z

libbeat/dashboards/kibana_loader.go

+	var indexContent common.MapStr
+	err = json.Unmarshal(reader, &indexContent)
+	if err != nil {
+		return fmt.Errorf("fail to unmarshal the index content: %v", err)


s/fail/failed/ -> not sure which one we shoud use, but we should be consistent :-)

I always using fail instead of failed. Not sure what is more widely used.

ruflin · 2017-08-25T08:24:20Z

libbeat/dashboards/modify_json.go

+	var record common.MapStr
+	err := json.Unmarshal([]byte(savedObject), &record)
+	if err != nil {
+		return "", fmt.Errorf("Failed to unmarshal searchSourceJSON from search : %v", err)


failed lower case

ruflin · 2017-08-25T08:24:29Z

libbeat/dashboards/modify_json.go

+	}
+	searchSourceJSON, err := json.Marshal(record)
+	if err != nil {
+		return "", fmt.Errorf("Failed to marshal searchSourceJSON: %v", err)


failed lower case

ruflin · 2017-08-25T08:25:05Z

libbeat/setup/kibana/client.go

+
+	body, err := json.Marshal(jsonBody)
+	if err != nil {
+		logp.Warn("Failed to json encode body (%v): %#v", err, jsonBody)


should this be an Err instead of Warning?

…rds (elastic#4949) (cherry picked from commit 6130ef3)

…rds (#4949) (#5018) (cherry picked from commit 6130ef3)

…rds (elastic#4949) (elastic#5018) (cherry picked from commit 36932d6)

monicasarbu added :Dashboards in progress Pull request is currently in progress. review and removed in progress Pull request is currently in progress. labels Aug 18, 2017

monicasarbu force-pushed the configure_index_pattern branch 2 times, most recently from d35e030 to 6f08c02 Compare August 21, 2017 09:06

monicasarbu added the in progress Pull request is currently in progress. label Aug 21, 2017

monicasarbu force-pushed the configure_index_pattern branch from e3ac988 to 4c20a52 Compare August 21, 2017 11:29

monicasarbu removed the in progress Pull request is currently in progress. label Aug 21, 2017

monicasarbu added the v6.0.0-beta2 label Aug 21, 2017

monicasarbu mentioned this pull request Aug 21, 2017

Loading dashboards improvements #4863

Closed

5 tasks

ruflin reviewed Aug 22, 2017

View reviewed changes

tsg added the needs_backport PR is waiting to be backported to other branches. label Aug 24, 2017

monicasarbu force-pushed the configure_index_pattern branch from 4c20a52 to 1b4440b Compare August 24, 2017 13:02

monicasarbu force-pushed the configure_index_pattern branch from dc443c0 to eafcedc Compare August 24, 2017 14:57

ruflin approved these changes Aug 25, 2017

View reviewed changes

monicasarbu force-pushed the configure_index_pattern branch 2 times, most recently from e1b303c to 91e861b Compare August 25, 2017 09:46

Make the index name configurable when loading the 6.x and 5.x dashboards

729dad6

monicasarbu force-pushed the configure_index_pattern branch from 39d7b67 to 729dad6 Compare August 25, 2017 09:51

tsg merged commit 6130ef3 into elastic:master Aug 25, 2017

tsg pushed a commit to tsg/beats that referenced this pull request Aug 25, 2017

Make the index name configurable when loading the 6.x and 5.x dashboa…

58b1a9c

…rds (elastic#4949) (cherry picked from commit 6130ef3)

tsg mentioned this pull request Aug 25, 2017

Cherry-pick #4949 to 6.0: Change index name in the dashboards and index-pattern #5018

Merged

tsg removed the needs_backport PR is waiting to be backported to other branches. label Aug 25, 2017

ruflin pushed a commit that referenced this pull request Aug 25, 2017

Make the index name configurable when loading the 6.x and 5.x dashboa…

6f68178

…rds (#4949) (#5018) (cherry picked from commit 6130ef3)

leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023

Make the index name configurable when loading the 6.x and 5.x dashboa…

688882e

…rds (elastic#4949) (elastic#5018) (cherry picked from commit 36932d6)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change index name in the dashboards and index-pattern #4949

Change index name in the dashboards and index-pattern #4949

monicasarbu commented Aug 18, 2017 •

edited

Loading

monicasarbu commented Aug 21, 2017

ruflin Aug 22, 2017

ruflin commented Aug 22, 2017 •

edited

Loading

monicasarbu commented Aug 24, 2017

monicasarbu commented Aug 24, 2017

ruflin left a comment

ruflin Aug 25, 2017

ruflin Aug 25, 2017

ruflin Aug 25, 2017

ruflin Aug 25, 2017

monicasarbu Aug 25, 2017

ruflin Aug 25, 2017

ruflin Aug 25, 2017

ruflin Aug 25, 2017

Change index name in the dashboards and index-pattern #4949

Change index name in the dashboards and index-pattern #4949

Conversation

monicasarbu commented Aug 18, 2017 • edited Loading

monicasarbu commented Aug 21, 2017

Choose a reason for hiding this comment

ruflin commented Aug 22, 2017 • edited Loading

monicasarbu commented Aug 24, 2017

monicasarbu commented Aug 24, 2017

ruflin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

monicasarbu commented Aug 18, 2017 •

edited

Loading

ruflin commented Aug 22, 2017 •

edited

Loading