Change deprecated _default_ mapping to doc in index templates #4864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruflin
reviewed
Aug 10, 2017
libbeat/template/template.go
Outdated
| @@ -128,7 +128,7 @@ func (t *Template) generate(properties common.MapStr, dynamicTemplates []common. | |||
| } | |||
|
|
|||
| if t.esVersion.IsMajor(2) || t.esVersion.IsMajor(5) { | |||
| basicStructure.Put("mappings._default_._all.norms.enabled", false) | |||
There was a problem hiding this comment.
@urso We also use doc for all types if we write to indices from 5.x with the ES output? Just want to make sure this also works with older versions of ES.
kvch
force-pushed
the
fix/deprecated-default-index-template
branch
from
610753d to
b2778d9
Compare
kvch
force-pushed
the
fix/deprecated-default-index-template
branch
from
b2778d9 to
f6878df
Compare
|
I merged this one, I think it's safe. @ruflin, please speak up if you have any concerns. |
tsg
pushed a commit
to tsg/beats
that referenced
this pull request
Aug 25, 2017
elastic#4864) Closes elastic#4840 (cherry picked from commit 5a5e210)
ruflin
pushed a commit
that referenced
this pull request
Aug 28, 2017
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
elastic#4864) (elastic#5019) Closes elastic#4840 (cherry picked from commit b0d48da)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_default_has been changed todocas seen in this example: https://www.elastic.co/guide/en/elasticsearch/reference/master/mapping.html#_example_mappingCloses #4840