Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support to exclude labels from kubernetes pod metadata #4757

Merged
merged 2 commits into from
Jul 26, 2017

Conversation

vjsamuel
Copy link
Contributor

We have seen instances where there are labels that have too high of a cardinality for which support to exclude/filter out would be good to have on the add_kubernetes_metadata processor.

@elasticmachine
Copy link
Collaborator

Can one of the admins verify this patch?

@vjsamuel vjsamuel force-pushed the add_exclude_labels branch from 8f87cdd to e3a194b Compare July 26, 2017 06:34
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically on build-eu-00. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@vjsamuel vjsamuel force-pushed the add_exclude_labels branch from e3a194b to 76bf3f9 Compare July 26, 2017 06:39
Copy link
Contributor

@exekias exekias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@exekias
Copy link
Contributor

exekias commented Jul 26, 2017

jenkins test it please

@exekias exekias added enhancement Metricbeat Metricbeat needs_backport PR is waiting to be backported to other branches. libbeat and removed Metricbeat Metricbeat labels Jul 26, 2017
@exekias exekias merged commit 18474a6 into elastic:master Jul 26, 2017
@vjsamuel vjsamuel deleted the add_exclude_labels branch July 26, 2017 14:59
@exekias exekias removed the needs_backport PR is waiting to be backported to other branches. label Aug 24, 2017
exekias pushed a commit to exekias/beats that referenced this pull request Aug 24, 2017
tsg pushed a commit that referenced this pull request Aug 24, 2017
@jstangroome jstangroome mentioned this pull request Nov 14, 2017
10 tasks
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants