Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename heartbeat packages #4601

Merged
merged 3 commits into from
Jul 4, 2017
Merged

Conversation

tsg
Copy link
Contributor

@tsg tsg commented Jul 3, 2017

Due to a naming conflict on Debian (see #3765), we rename the name of the
RPM and DEB packages to be heartbeat-elastic. The artifacts that we offer for
download are still named heartbeat, only the package names in the repositories
will be heartbeat-elastic.

The init scripts and the service files are renamed, as well as the PID files
and setting files (e.g. /etc/default/heartbeat-elastic). The binaries, config
files, etc are not, so the changes are minimal.

Fixes #3765.

ToDOs:

  • Changelog
  • Docs updates

@tsg tsg added :Packaging in progress Pull request is currently in progress. review labels Jul 3, 2017
@tsg
Copy link
Contributor Author

tsg commented Jul 3, 2017

jenkins, package it

@tsg
Copy link
Contributor Author

tsg commented Jul 3, 2017

Packaging tests are good: http://build-eu-00.elastic.co/job/beats-package-PR/110/

@tsg tsg removed the in progress Pull request is currently in progress. label Jul 4, 2017
Tudor Golubenco added 3 commits July 4, 2017 11:15
Due to a naming conflict on Debian (see elastic#3765), we rename the name of the
RPM and DEB packages to be `heartbeat-elastic`. The artifacts that we offer for
download are still named `heartbeat`, only the package names in the repositories
will be `heartbeat-elastic`.

The init scripts and the service files are renamed, as well as the PID files
and setting files (e.g. `/etc/default/heartbeat-elastic`). The binaries, config
files, etc are not, so the changes are minimal.

Fixes elastic#3765.
@tsg tsg force-pushed the rename_heartbeat_packages branch from a976110 to 8ab7461 Compare July 4, 2017 09:15
Copy link
Contributor

@exekias exekias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFG

@tsg
Copy link
Contributor Author

tsg commented Jul 4, 2017

jenkins, test it

@exekias exekias merged commit f3cabcd into elastic:master Jul 4, 2017
@tsg tsg mentioned this pull request Jul 24, 2017
28 tasks
brianvans added a commit to brianvans/chef-heartbeat that referenced this pull request Mar 30, 2018
Due to a naming conflict on Debian, the package and service were
namespaced diffrently from 6 onwards

See elastic/beats#4601
brianvans added a commit to brianvans/chef-heartbeat that referenced this pull request Mar 30, 2018
Due to a naming conflict on Debian, the package and service were
namespaced diffrently from 6 onwards

See elastic/beats#4601
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants