-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename heartbeat packages #4601
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenkins, package it |
Packaging tests are good: http://build-eu-00.elastic.co/job/beats-package-PR/110/ |
Due to a naming conflict on Debian (see elastic#3765), we rename the name of the RPM and DEB packages to be `heartbeat-elastic`. The artifacts that we offer for download are still named `heartbeat`, only the package names in the repositories will be `heartbeat-elastic`. The init scripts and the service files are renamed, as well as the PID files and setting files (e.g. `/etc/default/heartbeat-elastic`). The binaries, config files, etc are not, so the changes are minimal. Fixes elastic#3765.
tsg
force-pushed
the
rename_heartbeat_packages
branch
from
July 4, 2017 09:15
a976110
to
8ab7461
Compare
exekias
approved these changes
Jul 4, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WFG
jenkins, test it |
brianvans
added a commit
to brianvans/chef-heartbeat
that referenced
this pull request
Mar 30, 2018
Due to a naming conflict on Debian, the package and service were namespaced diffrently from 6 onwards See elastic/beats#4601
brianvans
added a commit
to brianvans/chef-heartbeat
that referenced
this pull request
Mar 30, 2018
Due to a naming conflict on Debian, the package and service were namespaced diffrently from 6 onwards See elastic/beats#4601
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a naming conflict on Debian (see #3765), we rename the name of the
RPM and DEB packages to be
heartbeat-elastic
. The artifacts that we offer fordownload are still named
heartbeat
, only the package names in the repositorieswill be
heartbeat-elastic
.The init scripts and the service files are renamed, as well as the PID files
and setting files (e.g.
/etc/default/heartbeat-elastic
). The binaries, configfiles, etc are not, so the changes are minimal.
Fixes #3765.
ToDOs: