Test command #4590
Merged
Test command #4590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exekias
added
enhancement
in progress
exekias
force-pushed
the
test-command
branch
8 times, most recently
from
930f275 to
9e5cbfe
Compare
exekias
force-pushed
the
test-command
branch
2 times, most recently
from
3f56e23 to
d145d1a
Compare
andrewkroh
approved these changes
Jul 11, 2017
andrewkroh
reviewed
Jul 11, 2017
libbeat/tests/system/test_cmd.py
Outdated
|
|
||
| assert exit_code == 1 | ||
| assert self.log_contains('parse url... OK') | ||
| assert self.log_contains('dns lookup... ERROR lookup badhost: no such host') |
There was a problem hiding this comment.
I would be careful with matching the specific error message coming from the stdlib or the OS. This has bit me a few times when running my tests on different OSes and Golang versions.
elasticsearch: http://badhost:9200...
parse url... OK
connection...
parse host... OK
dns lookup... ERROR lookup badhost on 127.0.0.11:53: no such host
======================================================================
FAIL: Test test wrong output works
----------------------------------------------------------------------
Traceback (most recent call last):
File "/go/src/github.com/elastic/beats/libbeat/tests/system/test_cmd.py", line 169, in test_test_wrong_output
assert self.log_contains('dns lookup... ERROR lookup badhost: no such host')
|
jenkins retest this please |
|
thanks for the review, btw I had a pending check that color works on Mac, I guess you just confirmed it? |
|
Yeah, the color works in Terminal on macOS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a self-testing framework, different parts of beats can implement
Testableinterface to allow the user to test her settings.Current features:
example ERROR:
example OK:
TODO: